search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 59 forks source link

cancel installs input prompts #284

Closed olivier-haddad closed 3 years ago

olivier-haddad commented 3 years ago

Fixes #281 as requested here: https://github.com/ros-tooling/cross_compile/issues/281#issuecomment-751855047

This fix sets DEBIAN_FRONTEND env variable to noninteractive and thus cancels the installations prompts issued by some packages during rosdep-triggered installations.

codecov[bot] commented 3 years ago

Codecov Report

Merging #284 (5b6c3d4) into master (0f23868) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files          10       10           
  Lines         408      408           
=======================================
  Hits          376      376           
  Misses         32       32
Flag Coverage Δ
unittests 92.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f23868...5b6c3d4. Read the comment docs.

emersonknapp commented 3 years ago

Ah - @olivier-haddad you'll need to sign your commits to pass the DCO check - git commit --amend --signoff && git push --force should do it, since this is a single commit.