search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 59 forks source link

Remove blind except (caught by flake8-blind-except 0.2) #289

Closed emersonknapp closed 3 years ago

emersonknapp commented 3 years ago

New release caused build to start failing https://pypi.org/project/flake8-blind-except/0.2.0/

I might have pinned back the dependency instead, but it's not a bad catch, so I'd rather just fix the linter complaint

codecov[bot] commented 3 years ago

Codecov Report

Merging #289 (18a728a) into master (2a5912f) will increase coverage by 0.91%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   92.15%   93.06%   +0.91%     
==========================================
  Files          10       10              
  Lines         408      404       -4     
==========================================
  Hits          376      376              
+ Misses         32       28       -4
Flag Coverage Δ
unittests 93.06% <0.00%> (+0.91%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ros_cross_compile/ros_cross_compile.py 85.36% <0.00%> (+3.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a5912f...18a728a. Read the comment docs.