Closed TSC21 closed 3 years ago
Run the tox
tests with success locally:
---------------------------------------------------------------------------------------------------------------------- live log call -----------------------------------------------------------------------------------------------------------------------
INFO ros_cross_compile.sysroot_creator:sysroot_creator.py:126 Building sysroot image: nuno/aarch64-ubuntu-eloquent:latest
INFO ros_cross_compile.sysroot_creator:sysroot_creator.py:135 Successfully created sysroot docker image: nuno/aarch64-ubuntu-eloquent:latest
PASSED [ 98%]
test/test_sysroot_creator.py::test_create_sysroot_stage_creation PASSED [100%]
----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml
============================================================================================================== 52 passed in 717.57s (0:11:57) ==============================================================================================================
_________________________________________________________________________________________________________________________ summary __________________________________________________________________________________________________________________________
py: commands succeeded
congratulations :)
This looks good to me, but I'd defer to someone who knows more about cross_compile. I approved the CI run and it's looking good though! The shellcheck linter failure is not new.
Merging #315 (a31a48b) into master (2a4b3b8) will increase coverage by
0.15%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 93.08% 93.23% +0.15%
==========================================
Files 11 11
Lines 405 414 +9
==========================================
+ Hits 377 386 +9
Misses 28 28
Flag | Coverage Δ | |
---|---|---|
unittests | 93.23% <100.00%> (+0.15%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
ros_cross_compile/platform.py | 100.00% <100.00%> (ø) |
|
ros_cross_compile/data_collector.py | 96.72% <0.00%> (+0.05%) |
:arrow_up: |
ros_cross_compile/pipeline_stages.py | 94.11% <0.00%> (+0.78%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a9c8253...a31a48b. Read the comment docs.
This looks good to me, but I'd defer to someone who knows more about cross_compile. I approved the CI run and it's looking good though! The shellcheck linter failure is not new.
@christophebedard thanks! I guess we wait on @emersonknapp?
@christophebedard thanks! I guess we wait on @emersonknapp?
yeah, unless someone else can review.
@christophebedard thanks! I guess we wait on @emersonknapp?
yeah, unless someone else can review.
This is somewhat a development blocker so would be great to have someone reviewing it.
@emersonknapp should be good now. Can you issue a new release in PyPi so this is made available by pip
?
CI doesn't seem to be moving for some reason
Please be patient - you've added a few dimensions to the test matrix - and the queue is currently backed up. Once it passes I'll merge this, and we can cut a pip release after that. We can expect to have the new version on PyPI by EOD tomorrow.
Please be patient - you've added a few dimensions to the test matrix - and the queue is currently backed up. Once it passes I'll merge this, and we can cut a pip release after that. We can expect to have the new version on PyPI by EOD tomorrow.
Well I do believe that it's just Github Actions queueing for no reason. Before it was much quicker to process them. Thanks for reviewing this and for merging it!
The release is out https://pypi.org/project/ros-cross-compile/0.7.0/
The release is out https://pypi.org/project/ros-cross-compile/0.7.0/
@emersonknapp thanks!
This pull request adds support for using this tool with ROS2 Galactic.