Closed TSC21 closed 3 years ago
this doesn't seem to be required - otherwise I guess the daily tests would be failing as well, and they aren't. Closing
Actually this needs to still be fixed: although the current key works for x86_64
, it doesn't work for aarch64
:
INFO:Docker Client: The following signatures were invalid: EXPKEYSIG F42ED6FBAB17C654 Open Robotics <info@osrfoundation.org>
All tests pass now and I am able to use the tool for aarch64
:
------------------------------------------------------------------------------------------------------------------- live log call -------------------------------------------------------------------------------------------------------------------
INFO ros_cross_compile.sysroot_creator:sysroot_creator.py:126 Building sysroot image: nuno/aarch64-ubuntu-eloquent:latest
INFO ros_cross_compile.sysroot_creator:sysroot_creator.py:135 Successfully created sysroot docker image: nuno/aarch64-ubuntu-eloquent:latest
PASSED [ 98%]
test/test_sysroot_creator.py::test_create_sysroot_stage_creation PASSED [100%]
----------- coverage: platform linux, python 3.8.5-final-0 -----------
Coverage XML written to file coverage.xml
========================================================================================================== 52 passed in 581.64s (0:09:41) ===========================================================================================================
______________________________________________________________________________________________________________________ summary ______________________________________________________________________________________________________________________
py: commands succeeded
congratulations :)
Merging #317 (930d715) into master (70a095e) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 11 11
Lines 414 414
=======================================
Hits 386 386
Misses 28 28
Flag | Coverage Δ | |
---|---|---|
unittests | 93.23% <100.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
ros_cross_compile/platform.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 70a095e...930d715. Read the comment docs.
Just one comment that I would like to keep the EOL distros as allowable inputs in case somebody wants to build them from source. Fine to remove the EOL distros from any important testing though.
The tool will fail to fetch the GPG keys to Eloquent. That's why CI failed initially. And that's why I decided to remove them in the first place. I don't really see a reason to keep them, considering they are EOL. Pleople can always use a previous version of the tool to build them. We can always add a notice on the README regarding the distros deprecations per version.
@emersonknapp thanks! Can you issue a 0.8.0 release with this?
Following https://discourse.ros.org/t/ros-gpg-key-expiration-incident/20669, this fix has to happen, otherwise the tool is unusable.