Closed hidmic closed 3 years ago
Most jobs are failing because of unrelated reasons. I have to take a closer look at the shellcheck
one though.
Rebased to please workflows.
Merging #322 (acaa7c1) into master (2795a54) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head acaa7c1 differs from pull request most recent head eb499d9. Consider uploading reports for the commit eb499d9 to get more accurate results
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 11 11
Lines 414 414
=======================================
Hits 386 386
Misses 28 28
Flag | Coverage Δ | |
---|---|---|
unittests | 93.23% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2795a54...eb499d9. Read the comment docs.
Does this mean we can eventually use this to support workspace overlaying and so answer to https://github.com/ros-tooling/cross_compile/issues/299?
It seems like you could mount an underlay workspace into the custom-data-dir
, then source it in custom-data/setup.bash
- so theoretically yes, though I haven't tried it. Would love to hear back if that works, and if so, an addition to the README explaining this workflow would be really useful.
Just a means to control the build environment. I do not have a strong opinion about how this is achieved (as long as there is a way). As such, I'm open to completely changing this patch if a more suitable alternative exists.
Thanks for the tool BTW !