search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 59 forks source link

build_workspace: increase verbosity of the colcon build command #323

Closed TSC21 closed 3 years ago

TSC21 commented 3 years ago

I see it as useful, specially for longer builds where we want to capture the output.

TSC21 commented 3 years ago

@emersonknapp the mypy tests are failing. can it be related with your last commits?

codecov[bot] commented 3 years ago

Codecov Report

Merging #323 (0562e20) into master (c5cb4de) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 0562e20 differs from pull request most recent head a95c620. Consider uploading reports for the commit a95c620 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          11       11           
  Lines         414      414           
=======================================
  Hits          386      386           
  Misses         28       28
Flag Coverage Δ
unittests 93.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ros_cross_compile/data_collector.py 96.72% <100.00%> (ø)
ros_cross_compile/dependencies.py 100.00% <100.00%> (ø)
ros_cross_compile/sysroot_creator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c5cb4de...a95c620. Read the comment docs.

emersonknapp commented 3 years ago

the mypy tests are failing. can it be related with your last commits?

it might, taking a look

TSC21 commented 3 years ago

the mypy tests are failing. can it be related with your last commits?

it might, taking a look

I got it solved with https://github.com/ros-tooling/cross_compile/pull/323/commits/0562e202043ff85b7e798a9f083afb40d6f60d22. although I am not certain I would this be required now. Maybe some previous commit downgraded the mypy version being installed for some reason? Or maybe it's just a coincidence and something got updated in tox. Anyway, this makes it work from Python 3.5 to 3.8.

TSC21 commented 3 years ago

@emersonknapp all good here? Anything missing? Do you agree with the change set?