search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 59 forks source link

Add qemu binaries to package_data #324

Closed hidmic closed 3 years ago

hidmic commented 3 years ago

Follow-up after https://github.com/ros-tooling/cross_compile/pull/319. Binaries do not have a file extension.

hidmic commented 3 years ago

Test failures are unrelated to this patch. It's all mypy complaints.

hidmic commented 3 years ago

@emersonknapp it won't auto-merge with failing checks, will it? Test failures seem unrelated and preexisting (or maybe not?):

test/test_colcon_mixins.py:24:1: error: Library stubs not installed for "pkg_resources" (or incompatible with Python 3.7)
test/test_colcon_mixins.py:24:1: note: Hint: "python3 -m pip install types-pkg_resources"
test/test_colcon_mixins.py:24:1: note: (or run "mypy --install-types" to install all missing stub packages)
test/test_colcon_mixins.py:24:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
hidmic commented 3 years ago

It appears issues are solved by #323.

emersonknapp commented 3 years ago

I've merged after visual analysis that it's the mypy issue - but would like to get that one fixed asap. Discussing on #323

TSC21 commented 3 years ago

@hidmic nice catch! Thanks!