search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 59 forks source link

Fix mypy by adding types-pkg_resources, and removing Python3.5 support #326

Closed emersonknapp closed 3 years ago

emersonknapp commented 3 years ago

Python3.5 was deprecated and reached EOL in 2020. The original reason to support this was for Dashing users, which supported 3.5. However, Dashing has also reached EOL. Moving forward we should not bother supporting a deprecated Python version.

types-pkg_resources fixes the Python3.6+ builds. Not sure exactly what happened to make this necessary, but it's a simple enough fix.

codecov[bot] commented 3 years ago

Codecov Report

Merging #326 (698e093) into master (d14b29a) will not change coverage. The diff coverage is 0.00%.

:exclamation: Current head 698e093 differs from pull request most recent head ec867aa. Consider uploading reports for the commit ec867aa to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          11       11           
  Lines         414      414           
=======================================
  Hits          386      386           
  Misses         28       28
Flag Coverage Δ
unittests 93.23% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ros_cross_compile/ros_cross_compile.py 85.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6de282c...ec867aa. Read the comment docs.