search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Fix: Wrong link to `mixins/index.yaml` in Dockerfile_workspace #35

Closed deitry closed 5 years ago

deitry commented 5 years ago

I was trying to cross compile ROS2 to armhf architecture and discovered that link to mixins/index.yaml is broken. This PR fix it, but shouldn't sysroot_compiler use local file instead?

Outside of this, there is no remark in README that Dockerfile_workspace should be putted into sysroot folder. If this is correct, I guess it should be stated here: https://github.com/ros-tooling/cross_compile#3-run-the-cross-compilation-script . At least I couldn't get it to work until I put it there.

Connected to this - maybe it should be stated explicitely that argument --sysroot-path must be absolute path; that took some time to realise why sysroot/Dockerfile_workspace was not found.

thomas-moulard commented 5 years ago

@piraka9011 @prajakta-gokhale Could you please take a look? Thanks!

piraka9011 commented 5 years ago

Regarding the installation instructions, yes, this is something we can fix. I am going through the instructions right now on a fresh system and have noted some minor things to update. Will make a PR for them.

prajakta-gokhale commented 5 years ago

Thanks for the fix @deitry! I created https://github.com/ros-tooling/cross_compile/issues/36 for fixing installation instructions and we are working on it.

deitry commented 5 years ago

Many thanks!