Closed prajakta-gokhale closed 4 years ago
Feedback from https://github.com/ros-tooling/cross_compile/pull/35
There is no remark in README that Dockerfile_workspace should be putted into sysroot folder. If this is correct, I guess it should be stated here: https://github.com/ros-tooling/cross_compile#3-run-the-cross-compilation-script . At least I couldn't get it to work until I put it there.
Connected to this - maybe it should be stated explicitely that argument --sysroot-path must be absolute path; that took some time to realise why sysroot/Dockerfile_workspace was not found.
Both issues have been fixed.
Feedback from https://github.com/ros-tooling/cross_compile/pull/35
There is no remark in README that Dockerfile_workspace should be putted into sysroot folder. If this is correct, I guess it should be stated here: https://github.com/ros-tooling/cross_compile#3-run-the-cross-compilation-script . At least I couldn't get it to work until I put it there.
Connected to this - maybe it should be stated explicitely that argument --sysroot-path must be absolute path; that took some time to realise why sysroot/Dockerfile_workspace was not found.