Closed Le5tes closed 1 year ago
@Le5tes I don't mind about this fix. I am only worry about failing tests on CI. Could you please try to fix warnings reported from linters?
=================================== FAILURES ===================================
_________________________________ test_flake8 __________________________________
@pytest.mark.flake8
@pytest.mark.linter
def test_flake8():
logging.getLogger('flake8').setLevel(logging.INFO)
rc = main(argv=[])
> assert rc == 0, 'Found errors'
E AssertionError: Found errors
E assert 1 == 0
E +1
E -0
test/test_flake8.py:26: AssertionError
----------------------------- Captured stdout call -----------------------------
./ros_cross_compile/docker_client.py:72:26: Q000 Double quotes found but single quotes preferred
network_mode="host"
^
1 Q000 Double quotes found but single quotes preferred
Base: 93.01% // Head: 92.99% // Decreases project coverage by -0.01%
:warning:
Coverage data is based on head (
2ba8acc
) compared to base (0caa4cd
). Patch has no changes to coverable lines.:exclamation: Current head 2ba8acc differs from pull request most recent head 9b693b7. Consider uploading reports for the commit 9b693b7 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks okay to me. Could you sign off your commit(s) so that they pass the DCO check? https://github.com/ros-tooling/cross_compile/pull/361/checks?check_run_id=7336140466
Not sure what's going on with the shellcheck linter failure. The other failures are in the nightly job as well: https://github.com/ros-tooling/cross_compile/actions/runs/2665228259
I signed off the commits. I'll have a look into the test failures a bit over the weekend.
@Le5tes Could you please address linter errors in you PR? We are going to archive entire repo very soon and this is last chance to get it throw.
@Le5tes Could you please address linter errors in you PR? We are going to archive entire repo very soon and this is last chance to get it throw.
@MichaelOrlov can you please clarify what this means? Are you guys stopping supporting the tool?
@Le5tes Yes we are going to archive this repo and deprecate. The rational for that:
This fixes the bug that I had: https://github.com/ros-tooling/cross_compile/issues/360
Not sure if anyone else is having this issue, so if not feel free to ignore!