Closed MichaelOrlov closed 1 year ago
@christophebedard @emersonknapp shellchecker
passing green now - could you please approve this PR?
Looks fine to me. Were the other tests failing already?
Base: 92.99% // Head: 92.97% // Decreases project coverage by -0.01%
:warning:
Coverage data is based on head (
0fa146b
) compared to base (0fb22b8
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@emersonknapp @christophebedard Do you know how to merge this PR? I don't see any other options rather than with automerge and some jobs are failing
I think the failures are all due to old distros or mismatched ROS distro and Ubuntu distro (Rolling is on 22.04 now). #369 is supposed to fix that, but there's still some CI failures. In any case, this PR only modifies the shellcheck job.
Do you know how to merge this PR? I don't see any other options rather than with automerge and some jobs are failing
I can do it.
Trying to fix shell checker by switching to the
reviewdog
version of it Previous versionzbeekman/ShellCheck-Linter-Action@v1.0.1
became deprecatedSigned-off-by: Michael Orlov michael.orlov@apex.ai