search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
187 stars 59 forks source link

Trying to fix shell checker by switching to the reviewdog version of it #370

Closed MichaelOrlov closed 1 year ago

MichaelOrlov commented 1 year ago

Trying to fix shell checker by switching to the reviewdog version of it Previous version zbeekman/ShellCheck-Linter-Action@v1.0.1 became deprecated

Signed-off-by: Michael Orlov michael.orlov@apex.ai

MichaelOrlov commented 1 year ago

@christophebedard @emersonknapp shellchecker passing green now - could you please approve this PR?

emersonknapp commented 1 year ago

Looks fine to me. Were the other tests failing already?

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.99% // Head: 92.97% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (0fa146b) compared to base (0fb22b8). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #370 +/- ## ========================================== - Coverage 92.99% 92.97% -0.02% ========================================== Files 11 10 -1 Lines 414 413 -1 ========================================== - Hits 385 384 -1 Misses 29 29 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `92.97% <ø> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/ros-tooling/cross_compile/pull/370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling) | Coverage Δ | | |---|---|---| | [ros\_cross\_compile/\_\_init\_\_.py](https://codecov.io/gh/ros-tooling/cross_compile/pull/370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#diff-cm9zX2Nyb3NzX2NvbXBpbGUvX19pbml0X18ucHk=) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

MichaelOrlov commented 1 year ago

@emersonknapp @christophebedard Do you know how to merge this PR? I don't see any other options rather than with automerge and some jobs are failing

christophebedard commented 1 year ago

I think the failures are all due to old distros or mismatched ROS distro and Ubuntu distro (Rolling is on 22.04 now). #369 is supposed to fix that, but there's still some CI failures. In any case, this PR only modifies the shellcheck job.

Do you know how to merge this PR? I don't see any other options rather than with automerge and some jobs are failing

I can do it.