ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
187 stars 59 forks source link

Updates to follow the updated rep 2000 #372

Closed MichaelOrlov closed 1 year ago

MichaelOrlov commented 1 year ago

Solve this issue https://github.com/ros-tooling/cross_compile/issues/368#issue-1464483861

Note: I cherry picked original commit and add fixes for e2e tests since original fork doesn't allow to push commits from repo maintainers.

MichaelOrlov commented 1 year ago

@christophebedard @emersonknapp Debian jobs still fails - and I don't know why. Your help in fixing it will be very appreciated.

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.97% // Head: 93.01% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (2196425) compared to base (1e1015d). Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #372 +/- ## ========================================== + Coverage 92.97% 93.01% +0.03% ========================================== Files 10 10 Lines 413 415 +2 ========================================== + Hits 384 386 +2 Misses 29 29 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `93.01% <80.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/ros-tooling/cross_compile/pull/372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling) | Coverage Δ | | |---|---|---| | [ros\_cross\_compile/ros\_cross\_compile.py](https://codecov.io/gh/ros-tooling/cross_compile/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#diff-cm9zX2Nyb3NzX2NvbXBpbGUvcm9zX2Nyb3NzX2NvbXBpbGUucHk=) | `85.36% <0.00%> (ø)` | | | [ros\_cross\_compile/dependencies.py](https://codecov.io/gh/ros-tooling/cross_compile/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#diff-cm9zX2Nyb3NzX2NvbXBpbGUvZGVwZW5kZW5jaWVzLnB5) | `100.00% <100.00%> (ø)` | | | [ros\_cross\_compile/platform.py](https://codecov.io/gh/ros-tooling/cross_compile/pull/372/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#diff-cm9zX2Nyb3NzX2NvbXBpbGUvcGxhdGZvcm0ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

emersonknapp commented 1 year ago

I see you fixed the Debian builds. Now it just looks like the test names changed, so we will need to change those requirements in the branch protection settings

christophebedard commented 1 year ago

I see you fixed the Debian builds. Now it just looks like the test names changed, so we will need to change those requirements in the branch protection settings

Done.

MichaelOrlov commented 1 year ago

Oof, I can't believe that I fixed all failing tests in this repo. It was too many failing jobs rather than just Debian and fixes was not so trivial.