ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

[WIP] Use git info to automatically determine the version number #57

Closed thomas-moulard closed 4 years ago

thomas-moulard commented 4 years ago

This introduces a dependency on setuptools-scm which expends setuptools to automatically determine the package version number based on git information.

This PR should not be merged until ros/rosdistro#22887 is merged as it declares the associated rosdep entry for setuptools-scm.

thomas-moulard commented 4 years ago

Not to be merged before ros/rosdistro#22887

codecov[bot] commented 4 years ago

Codecov Report

Merging #57 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #57   +/-   ##
=======================================
  Coverage   63.56%   63.56%           
=======================================
  Files           4        4           
  Lines         269      269           
=======================================
  Hits          171      171           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 500e3d1...c8854a3. Read the comment docs.

nuclearsandwich commented 4 years ago

I don't know if the intention is to eventually distribute cross_compile on the ROS buildfarm but source packages are built in a container without build dependencies and so cannot handle packages which have setup.py requirements beyond the basic python and setuptools.

thomas-moulard commented 4 years ago

@nuclearsandwich thanks for the precision - I thought it would respect buildtool_depends, but it seems this is not the case. Anyway to express a dependency at this stage?

thomas-moulard commented 4 years ago

Closing at this seems it won't work. I'll try to get the version number from the package.xml instead. That will be more consistent anyway.

nuclearsandwich commented 4 years ago

Anyway to express a dependency at this stage?

No. Python3 is available to facilitate the dh_python debhelper extension which pulls in distutils and setuptools. The full list is here: https://github.com/ros-infrastructure/ros_buildfarm/blob/b78c453bb1c8a4829ebc26350d3671fcbdedf1c4/ros_buildfarm/templates/release/sourcedeb_task.Dockerfile.em#L39-L51

thomas-moulard commented 4 years ago

@nuclearsandwich Thanks for your help, you're everywhere :)

nuclearsandwich commented 4 years ago

you're everywhere :)

Everywhere and nowhere.