Moved rmtree(target_sysroot) closer to sysroot_tar.extractall()

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets

Apache License 2.0

188 stars 60 forks source link

Moved rmtree(target_sysroot) closer to sysroot_tar.extractall() #63

Closed deitry closed 4 years ago

deitry commented 4 years ago

When encountered this I found after interrupt during export_workspace_sysroot_image() that there is no my former sysroot, which was very confusing.

IMO, the best way is to extract resulting tree into another folder than origin one in order to preserve original files, but following current script I propose to move rm command closer to tree extraction.

thomas-moulard commented 4 years ago

Thanks for the contribution!

@zmichaels11 could you PTAL? I think you have the most context about this piece of code.

thomas-moulard commented 4 years ago

Merged - thanks again!