emersonknapp commented 4 years ago

Make the documentation for the sysroot argument correct by defaulting to the current working directory.

Before this PR, if you didn't pass the argument, an error would be raised by the SysrootCompiler verifying its argument.

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #72 into master will decrease coverage by 0.23%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   62.86%   62.63%   -0.24%     
==========================================
  Files           4        4              
  Lines         272      273       +1     
==========================================
  Hits          171      171              
- Misses        101      102       +1

Impacted Files	Coverage Δ
.../cross_compile/cross_compile/ros2_cross_compile.py	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5e6bef6...d7823f1. Read the comment docs.

zmichaels11 commented 4 years ago

~These changes might be OS-specific: https://docs.python.org/3/library/os.html#files-and-directories~

ros-tooling / cross_compile

Make the documentation for the sysroot argument correct #72

Codecov Report