search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Don't overwrite user's source workspace #74

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Instead of exporting the sysroot and clobbering the source workspace, just extract the cross-compiled install directory and place it next to src. The sysroot is not currently required by the functionality and therefore should not be exposed.

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #74 into master will increase coverage by 0.89%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   64.28%   65.18%   +0.89%     
==========================================
  Files           4        4              
  Lines         252      247       -5     
==========================================
- Hits          162      161       -1     
+ Misses         90       86       -4
Impacted Files Coverage Δ
...rc/cross_compile/cross_compile/sysroot_compiler.py 65.62% <0%> (+1.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cb315e...2fea441. Read the comment docs.