Closed zmichaels11 closed 4 years ago
Merging #85 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 65.18% 65.18%
=======================================
Files 4 4
Lines 247 247
=======================================
Hits 161 161
Misses 86 86
Flag | Coverage Δ | |
---|---|---|
#unittests | 65.18% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c39a922...411e858. Read the comment docs.
~This causes some errors if ubuntu:latest
is used since libgcc 7
and libgcc 8
are both available~
This is good - i added a commit to properly source the ros dependencies that rosdep installed, if they exist
Why is there a whole new run_e2e_test_debian.sh
when we can just pass the --os
flag?
Also, if we want that script to be explicitly for debian, should we remove the option to specify the OS in the argparser?
Why is there a whole new
run_e2e_test_debian.sh
when we can just pass the--os
flag? Also, if we want that script to be explicitly for debian, should we remove the option to specify the OS in the argparser?
I didn't know that.
Removed e2e test and verified that ./run_e2e_test.sh --os debian
passes
Issues
84
80 (possibly)
81
Testing
test/run_e2e_test.sh
test/run_e2e_test_debian.sh