search

ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Don't pass argparse.Namespace out of the argument parsing context #88

Closed emersonknapp closed 4 years ago

emersonknapp commented 4 years ago

Be explicit about required arguments passed to constructors and their types.

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #88 into master will decrease coverage by 1.25%. The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   66.66%   65.41%   -1.25%     
==========================================
  Files           4        4              
  Lines         249      240       -9     
==========================================
- Hits          166      157       -9     
  Misses         83       83
Flag Coverage Δ
#unittests 65.41% <88.23%> (-1.25%) :arrow_down:
Impacted Files Coverage Δ
cross_compile/ros2_cross_compile.py 0% <0%> (ø) :arrow_up:
cross_compile/sysroot_compiler.py 66.41% <100%> (ø) :arrow_up:
test/test_sysroot_compiler.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e1361f...15d1bbf. Read the comment docs.