ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Remove Microsoft's repos #91

Closed piraka9011 closed 4 years ago

piraka9011 commented 4 years ago

Add a step to the build and test workflow removing the MS repos causing the workflow to fail.

A PR that reverts this change needs to be created and merged once an official fix has been released.

Signed-off-by: Anas Abou Allaban allabana@amazon.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #91 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files           4        4           
  Lines         236      236           
=======================================
  Hits          157      157           
  Misses         79       79
Flag Coverage Δ
#unittests 66.52% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5327cca...36a3681. Read the comment docs.

piraka9011 commented 4 years ago

Can you move the new step to the top?

It's already the first step?

thomas-moulard commented 4 years ago

Indeed, the diff is weird for some reason... Could you remove the ls and add a comment pointing to the oncall issue?

piraka9011 commented 4 years ago

This issue has been resolved by the GH team. https://github.community/t5/GitHub-Actions/ubuntu-latest-Apt-repository-list-issues/td-p/41122/page/2