ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Add Vale GH action #95

Closed piraka9011 closed 4 years ago

piraka9011 commented 4 years ago

Add the Vale GH action workflow.

Depends on:

Signed-off-by: Anas Abou Allaban allabana@amazon.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #95 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   69.69%   69.69%           
=======================================
  Files           4        4           
  Lines         264      264           
=======================================
  Hits          184      184           
  Misses         80       80
Flag Coverage Δ
#unittests 69.69% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfad615...0960ecf. Read the comment docs.

emersonknapp commented 4 years ago

Except - the Vale action prints this

Vale: Found 71 suggestion(s), 57 warning(s), and 20 error(s).

but doesn't go yellow or red, is this the intended behavior?

piraka9011 commented 4 years ago

... doesn't go yellow or red, is this the intended behavior?

No, see the following issue. It looks there's a fix in progress. Not sure how they got it working in their examples tho.

Playing around with the .vale.ini config file might resolve the issue.

emersonknapp commented 4 years ago

Does this PR replace https://github.com/ros-tooling/cross_compile/pull/77 ? If so, can you close that one with a note?

piraka9011 commented 4 years ago

Closing since the vale action doesn't seem to be working at the moment.