Closed piraka9011 closed 4 years ago
Merging #95 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 69.69% 69.69%
=======================================
Files 4 4
Lines 264 264
=======================================
Hits 184 184
Misses 80 80
Flag | Coverage Δ | |
---|---|---|
#unittests | 69.69% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bfad615...0960ecf. Read the comment docs.
Except - the Vale action prints this
Vale: Found 71 suggestion(s), 57 warning(s), and 20 error(s).
but doesn't go yellow or red, is this the intended behavior?
... doesn't go yellow or red, is this the intended behavior?
No, see the following issue. It looks there's a fix in progress. Not sure how they got it working in their examples tho.
Playing around with the .vale.ini
config file might resolve the issue.
Does this PR replace https://github.com/ros-tooling/cross_compile/pull/77 ? If so, can you close that one with a note?
Closing since the vale action doesn't seem to be working at the moment.
Add the Vale GH action workflow.
Depends on:
Signed-off-by: Anas Abou Allaban allabana@amazon.com