ros-tooling / cross_compile

A tool to build ROS and ROS2 workspaces for various targets
Apache License 2.0
188 stars 60 forks source link

Add armhf platform to e2e tests #98

Closed prajakta-gokhale closed 4 years ago

prajakta-gokhale commented 4 years ago

Changes had to be made to the dockerfile for it to work correctly with Debian Buster and find correct sources lists from rosdep.

Signed-off-by: Prajakta Gokhale prajaktg@amazon.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #98 into master will increase coverage by 42.34%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #98       +/-   ##
===========================================
+ Coverage   27.35%   69.69%   +42.34%     
===========================================
  Files          78        4       -74     
  Lines        6138      264     -5874     
===========================================
- Hits         1679      184     -1495     
+ Misses       4459       80     -4379
Flag Coverage Δ
#unittests 69.69% <ø> (+42.34%) :arrow_up:
Impacted Files Coverage Δ
...gs/docker-4.1.0-py3.6.egg/docker/utils/__init__.py
.../docker-4.1.0-py3.6.egg/docker/utils/decorators.py
.eggs/docker-4.1.0-py3.6.egg/docker/utils/proxy.py
...cket_client-0.56.0-py3.6.egg/websocket/__init__.py
...eggs/docker-4.1.0-py3.6.egg/docker/api/__init__.py
...gs/docker-4.1.0-py3.6.egg/docker/models/volumes.py
...ker-4.1.0-py3.6.egg/docker/credentials/__init__.py
...eggs/docker-4.1.0-py3.6.egg/docker/models/nodes.py
...bsocket_client-0.56.0-py3.6.egg/websocket/_core.py
...gs/docker-4.1.0-py3.6.egg/docker/models/configs.py
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b3c80b...7320624. Read the comment docs.

prajakta-gokhale commented 4 years ago
  • Is only the change on L17 relevant to this PR?

No, they are all relevant. The other changes had to be made to fix test failures on armhf with debian buster for ROS 2 Eloquent.

  • What does L107 do?

rosdep init failed to download sources on armhf/buster/eloquent because it couldn't properly access the SSL certificates for it. (This seems to be a known problem, see this ROS answers post). The change on this line makes the certificates accessible to the command. See c_rehash man page.