search

ros-tooling / rosbag2_storage_mcap

rosbag2 storage implementation for MCAP file format
https://mcap.dev/
Apache License 2.0
32 stars 5 forks source link

Store IDL definitions in MCAP #53

Closed james-rms closed 2 years ago

james-rms commented 2 years ago

Adds logic to detect IDL-defined message types and store the IDL.

emersonknapp commented 2 years ago

Can a .msg use an IDL-defined subtype? If so, does this handle that? I couldn't quite tell from the code

james-rms commented 2 years ago

You're right, it can, and this code doesn't handle that (it'll fail with "file not found"). I can take a look at falling back to IDL if any dependency has no MSG definition.

james-rms commented 2 years ago

@emersonknapp ok, handled and tested.