search

ros-tooling / setup-ros-docker

2 stars 5 forks source link

Update colcon-* versions #42

Closed kenji-miyake closed 1 year ago

kenji-miyake commented 3 years ago

Resolves #41

christophebedard commented 3 years ago

This looks good to me, but since there's no tagging/versioning for these images, it means that, if someone is using an older version of action-ros-ci, their CI might start failing like https://github.com/ros-tooling/action-ros-ci/issues/615. I think we could just update everything but keep colcon-mixin to <0.1.10 in order to avoid failures like that and then figure out what to do about colcon-mixin afterwards.

kenji-miyake commented 3 years ago

@christophebedard I'm sorry, I forgot to change as you suggested. Now it's done. Also, as for the versioning, do you have any plan for that?

christophebedard commented 3 years ago

@christophebedard I'm sorry, I forgot to change as you suggested. Now it's done.

Thanks! Were you able to test it with action-ros-ci @ v0.2? It might also be a good idea to test it with v0.1 just to make sure it works and doesn't cause a regression.

Also, as for the versioning, do you have any plan for that?

I would let @emersonknapp answer this.

kenji-miyake commented 3 years ago

@christophebedard

Were you able to test it with action-ros-ci @ v0.2?

Not yet. How can I test with the Docker image that will be created in this PR? :thinking: I guess Docker images won't be published from PRs.

christophebedard commented 3 years ago

How can I test with the Docker image that will be created in this PR? I guess Docker images won't be published from PRs.

You can probably modify the workflow config on your fork and get it to build the image on a branch other than master. Then you can use the image from your fork (like kenji-miyake/setup-ros-docker:...).

kenji-miyake commented 3 years ago

@christophebedard Okay, I'll try it!

emersonknapp commented 1 year ago

Closing as stale for now - please open new PR if change will be worked on in the future