search

ros-tooling / setup-ros-docker

2 stars 5 forks source link

Install all rmw implementations #59

Closed christophebedard closed 11 months ago

christophebedard commented 11 months ago

Closes #58

christophebedard commented 11 months ago

Yeah. To satisfy #58 we'd need to install the rmw implementations in the base image, but then he might as well just install them right before the action-ros-ci step as he suggested here https://github.com/ros-tooling/setup-ros-docker/issues/58#issuecomment-1808742545. I think installing them in the non-empty images and letting users of the empty images install them themselves makes sense.