ros-tooling / setup-ros

Github Action to set up ROS 2 on hosts
Apache License 2.0
87 stars 41 forks source link

Update to latest binary ros2 windows distributions #548

Closed hoffmann-stefan closed 1 year ago

hoffmann-stefan commented 1 year ago

This updates to the latest windows binary distributions like this PR did: https://github.com/ros-tooling/setup-ros/pull/450

Doing this manually since https://github.com/ros-tooling/setup-ros/issues/453 isn't resolved yet.

Came across this when debugging the CI failure for this ros2_dotnet PR: https://github.com/ros2-dotnet/ros2_dotnet/pull/90#issuecomment-1314201102

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (163cec9) 93.18% compared to head (bb6a879) 93.18%.

:exclamation: Current head bb6a879 differs from pull request most recent head aada801. Consider uploading reports for the commit aada801 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #548 +/- ## ======================================= Coverage 93.18% 93.18% ======================================= Files 8 8 Lines 176 176 Branches 17 17 ======================================= Hits 164 164 Misses 12 12 ``` | [Impacted Files](https://codecov.io/gh/ros-tooling/setup-ros/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling) | Coverage Δ | | |---|---|---| | [src/setup-ros-windows.ts](https://codecov.io/gh/ros-tooling/setup-ros/pull/548?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#diff-c3JjL3NldHVwLXJvcy13aW5kb3dzLnRz) | `78.12% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hoffmann-stefan commented 1 year ago

@emersonknapp: Thanks for the quick merge!

When can we expect an release that includes this update? Is there some process or usual schedule for a release? Did use the merged version of this successfully on this PR, but it would be nice as well to have a tagged version there. But no hurries.

christophebedard commented 1 year ago

We just create new releases as needed. I'll create 0.6.1 now.

christophebedard commented 1 year ago

We just create new releases as needed. I'll create 0.6.1 now.

Done! https://github.com/ros-tooling/setup-ros/releases/tag/0.6.1