ros-tooling / setup-ros

Github Action to set up ROS 2 on hosts
Apache License 2.0
87 stars 41 forks source link

Add support for Iron #568

Closed hoffmann-stefan closed 1 year ago

hoffmann-stefan commented 1 year ago

Adds support for Iron.

This is the equivalent of those two PRs for Humble:

Came across this while doing the PR to add Iron CI to ros2_dotnet:

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (3bce810) 93.18% compared to head (fe2f6fe) 93.18%.

:exclamation: Current head fe2f6fe differs from pull request most recent head 7dce734. Consider uploading reports for the commit 7dce734 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #568 +/- ## ======================================= Coverage 93.18% 93.18% ======================================= Files 8 8 Lines 176 176 Branches 17 17 ======================================= Hits 164 164 Misses 12 12 ``` | [Impacted Files](https://app.codecov.io/gh/ros-tooling/setup-ros/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling) | Coverage Δ | | |---|---|---| | [src/setup-ros-windows.ts](https://app.codecov.io/gh/ros-tooling/setup-ros/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#diff-c3JjL3NldHVwLXJvcy13aW5kb3dzLnRz) | `78.12% <ø> (ø)` | | | [src/utils.ts](https://app.codecov.io/gh/ros-tooling/setup-ros/pull/568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ros-tooling#diff-c3JjL3V0aWxzLnRz) | `90.32% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

christophebedard commented 1 year ago

Thank you very much for doing this! I was going to do it eventually, but I'm a bit busy these days.

What version of Node are you using? This failure seems to indicate that there is a mismatch between the version you used to update the index.js file and the expected version: https://github.com/ros-tooling/setup-ros/actions/runs/5072876818/jobs/9111165183?pr=568

hoffmann-stefan commented 1 year ago

Using the following node version on ubuntu 20.04:

$ node --version
v16.20.0

did an npm install (was mising this initialy), npm run fixup and npm run build. Force pushed the amended commit, but didn't change anything...

christophebedard commented 1 year ago

Thanks for checking. I'll see if I can give it a shot on my end.

This job failure doesn't necessarily mean that something is wrong, but I'll double check.

christophebedard commented 1 year ago

Done! Released as 0.6.2/v0.6.