search

ros-tooling / setup-ros

Github Action to set up ROS 2 on hosts
Apache License 2.0
84 stars 39 forks source link

Fix prettier==3 and eslint-plugin-prettier==4 incompatibility #633

Closed christophebedard closed 9 months ago

christophebedard commented 9 months ago

We're getting this error when running npm run lint:

TypeError: prettier.resolveConfig.sync is not a function

Apparently, prettier==3 and eslint-plugin-prettier==4 are not compatible; we need to bump to eslint-plugin-prettier==5: https://stackoverflow.com/a/76625797/6476709.

Also, regenerate the dist file.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7293e28) 92.47% compared to head (35ad5d8) 92.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #633 +/- ## ======================================= Coverage 92.47% 92.47% ======================================= Files 8 8 Lines 186 186 Branches 22 22 ======================================= Hits 172 172 Misses 14 14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

christophebedard commented 9 months ago

This fixes the linter job, so I'll merge this.