search

ros-tooling / setup-ros

Github Action to set up ROS 2 on hosts
Apache License 2.0
84 stars 39 forks source link

Fix empy 5 issue with setup-ros for EOL distros #634

Closed christophebedard closed 8 months ago

christophebedard commented 8 months ago

The latest setup-ros version(s) drop(s) support for EOL distros (Galactic, Foxy, etc.), so users need to use older versions of setup-ros for those. We fixed an issue with empty 5 in #632, but, since we do not maintain older versions, the aforementioned users are stuck with a broken CI.

christophebedard commented 8 months ago

My proposal would be to turn v0.X tags into branches for the older versions that support EOL distros, backport the fix to those branches, and create new releases. I'll need to see how many branches I need to create, i.e., how many older v0.X versions we need to fix.

christophebedard commented 8 months ago

I did this for v0.6, which supports non-EOL distros + Melodic and Foxy: https://github.com/ros-tooling/setup-ros/blob/v0.6/src/utils.ts#L44-L51. The new release is 0.6.3 (or v0.6).

v0.5 supports Galactic, but it's been EOL for almost a year now, so I won't apply the fix to v0.5 unless someone requests it.

cc @francocipollone

christophebedard commented 8 months ago

cc @beniaminopozzan too

hoffmann-stefan commented 8 months ago

@christophebedard Thank you for the backport 👍

Just one note before this confuses you or someone else: You did not push the updated tag v0.6 to point to the same commit as v0.6.3, like you did for v0.7, but as there is now a branch called v0.6. GitHub Actions does pick up the branch instead of the tag. So everything is fine for people that use setup-ros@v0.6, but it is somewhat confusing why it picks up the right version ;)

chavasse commented 8 months ago

I did this for v0.6, which supports non-EOL distros + Melodic and Foxy: https://github.com/ros-tooling/setup-ros/blob/v0.6/src/utils.ts#L44-L51. The new release is 0.6.3 (or v0.6).

v0.5 supports Galactic, but it's been EOL for almost a year now, so I won't apply the fix to v0.5 unless someone requests it.

cc @francocipollone

Hey Chris! We still use Galactic (yes even though it's been EOL for almost a year...). Please could you backport these changes to v0.5 as well as it's broken our build process. Many thanks in advance! Chris

christophebedard commented 8 months ago

We still use Galactic (yes even though it's been EOL for almost a year...). Please could you backport these changes to v0.5 as well as it's broken our build process.

Sorry for the delay. I backported the fix and created a new v0.5/0.5.1 release.

I didn't test it, so let me know if you have any issues.

chavasse commented 8 months ago

Thank you so much - really appreciated 🙌