ARM build fails due to temp fix with grub-efi-amd64-signed - Githubissues

ros-tooling / setup-ros

Github Action to set up ROS 2 on hosts

Apache License 2.0

85 stars 39 forks source link

ARM build fails due to temp fix with grub-efi-amd64-signed #731

Closed johnsonTyler0511 closed 3 weeks ago

johnsonTyler0511 commented 3 weeks ago

Description

As of release 0.6 this small fix here https://github.com/ros-tooling/setup-ros/pull/543/files causes builds on arm systems to fail due to using an amd package. using release 0.5 setup_ros completes on arm linux system.

Expected Behavior

setup_ros should work on any linux system, and grab the correct packages not hardcoded for amd based system.

Actual Behavior

To Reproduce

run setup_ros action release >0.6 with an arm linux system

System (please complete the following information)

OS: Linux
ROS 2 Distro: Humble

using the arm64v8/ros:humble-ros-core docker image

christophebedard commented 3 weeks ago

So I guess we could just avoid that line if it's running on a non-amd64 system.

johnsonTyler0511 commented 3 weeks ago

that would be great or if there is a grub-efi-arm-signed package maybe that could work and help mitigate the original issue?

christophebedard commented 3 weeks ago

Can you give #732 a try? You can try it by using ros-tooling/setup-ros@christophebedard/workaround-support-arm64.

johnsonTyler0511 commented 3 weeks ago

looks like the change messed up the package name a bit which might be causing an issue:

christophebedard commented 3 weeks ago

oops, I need to strip the string.

johnsonTyler0511 commented 3 weeks ago

Looks like that fixed it, build passed :1st_place_medal: Thanks for the quick help!!

christophebedard commented 3 weeks ago

Alright, I'll merge it and release as 0.7.9/v0.7, so you'll need to use the latest version.

christophebedard commented 3 weeks ago

Alright, I'll merge it and release as 0.7.9/v0.7, so you'll need to use the latest version.

done!