ros-tooling / system_metrics_collector

[DEPRECATED] Lightweight, real-time system metrics collector for ROS2 systems
Apache License 2.0
18 stars 8 forks source link

Return descriptive error codes from e2e tests #140

Open prajakta-gokhale opened 4 years ago

prajakta-gokhale commented 4 years ago

Description

The e2e tests in this package return a numeric return code of 0 for success and 1 otherwise. This does not help identify the cause of build failures easily, without looking at the long logs produced.

Refactor the return code part in system_metrics_e2e_test and topic_statistics_e2e_test to make the failure code less generic and more descriptive of the cause of failure.

_Originally posted by @dabonnie in https://github.com/ros-tooling/system_metrics_collector/pull/125/files_

Test Plan

Documentation Plan

Release Plan

Acceptance Criteria

Once all above items are checked, this story can be moved to done.

Resources

dabonnie commented 4 years ago

Some context why descriptive return codes are useful: https://github.com/ros-tooling/action-ros-ci/issues/143