ros-tooling / system_metrics_collector

[DEPRECATED] Lightweight, real-time system metrics collector for ROS2 systems
Apache License 2.0
18 stars 8 forks source link

Fix build error and warning with latest version of core #192

Closed emersonknapp closed 3 years ago

emersonknapp commented 3 years ago

After https://github.com/ros2/rclcpp/pull/1442 - RCLCPP_DEBUG no longer accepts std::string, so we need to update those places to pass const char *.

(side note there was a build warning for the other string format - and I didn't want to have a PR with warnings)

codecov[bot] commented 3 years ago

Codecov Report

Merging #192 (ef625d3) into master (bf375a5) will decrease coverage by 5.28%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #192       +/-   ##
===========================================
- Coverage   34.62%   29.34%    -5.29%     
===========================================
  Files        3012       42     -2970     
  Lines      144506     1847   -142659     
  Branches    91701      918    -90783     
===========================================
- Hits        50042      542    -49500     
+ Misses       8464      445     -8019     
+ Partials    86000      860    -85140     
Flag Coverage Δ
unittests 29.34% <ø> (-5.29%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...etrics_collector/test_linux_memory_measurement.cpp
...llector/src/system_metrics_collector/utilities.cpp
...trics_collector/test_metrics_message_publisher.cpp
...m_metrics_collector/test_linux_cpu_measurement.cpp
...r/test/system_metrics_collector/test_utilities.cpp
...or/src/topic_statistics_collector/dummy_talker.cpp
...lector/test_linux_process_cpu_measurement_node.cpp
...or/src/topic_statistics_collector/dummy_talker.cpp
...ctor/src/system_metrics_collector/example_main.cpp
...ollector/linux_process_memory_measurement_node.cpp
... and 3020 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf375a5...ef625d3. Read the comment docs.