ros-tooling / system_metrics_collector

[DEPRECATED] Lightweight, real-time system metrics collector for ROS2 systems
Apache License 2.0
18 stars 8 forks source link

LinuxCpuMeasurementTestFixture.TestManualMeasurement test failure #83

Closed zmichaels11 closed 4 years ago

zmichaels11 commented 4 years ago

Description

  61% tests passed, 7 tests failed out of 18

  Label Time Summary:
  copyright     =   0.62 sec*proc (1 test)
  cppcheck      =   0.90 sec*proc (1 test)
  cpplint       =   1.86 sec*proc (1 test)
  flake8        =   0.98 sec*proc (1 test)
  gtest         =   3.41 sec*proc (10 tests)
  lint_cmake    =   0.57 sec*proc (1 test)
  linter        =   7.42 sec*proc (8 tests)
  pep257        =   0.66 sec*proc (1 test)
  uncrustify    =   1.10 sec*proc (1 test)
  xmllint       =   0.75 sec*proc (1 test)

  Total Test time (real) =  10.84 sec

  The following tests FAILED:
      2 - test_metrics_message_publisher (Failed)
      3 - test_linux_cpu_measurement_node (Failed)
      4 - test_linux_memory_measurement_node (Failed)
      5 - test_linux_process_cpu_measurement_node (Failed)
      6 - test_linux_process_memory_measurement_node (Failed)
      8 - test_periodic_measurement_node (Failed)
      9 - test_composition (Failed)

ASAN:

  61% tests passed, 7 tests failed out of 18

  Label Time Summary:
  copyright     =   0.50 sec*proc (1 test)
  cppcheck      =   0.74 sec*proc (1 test)
  cpplint       =   1.52 sec*proc (1 test)
  flake8        =   0.93 sec*proc (1 test)
  gtest         =   2.66 sec*proc (10 tests)
  lint_cmake    =   0.47 sec*proc (1 test)
  linter        =   6.32 sec*proc (8 tests)
  pep257        =   0.54 sec*proc (1 test)
  uncrustify    =   0.89 sec*proc (1 test)
  xmllint       =   0.73 sec*proc (1 test)

  Total Test time (real) =   8.98 sec

  The following tests FAILED:
      2 - test_metrics_message_publisher (Failed)
      3 - test_linux_cpu_measurement_node (Failed)
      4 - test_linux_memory_measurement_node (Failed)
      5 - test_linux_process_cpu_measurement_node (Failed)
      6 - test_linux_process_memory_measurement_node (Failed)
      8 - test_periodic_measurement_node (Failed)
      9 - test_composition (Failed)
  Errors while running CTest

System (please complete the following information)

zmichaels11 commented 4 years ago

In LinuxCpuMeasurementTestFixture.TestManualMeasurement

==12360== Conditional jump or move depends on uninitialised value(s)
==12360==    at 0x11CC19: isnan (cmath:627)
==12360==    by 0x11CC19: LinuxCpuMeasurementTestFixture_TestManualMeasurement_Test::TestBody() (test_linux_cpu_measurement.cpp:262)
==12360==    by 0x1576C9: HandleSehExceptionsInMethodIfSupported<testing::Test, void> (gtest.cc:2447)
==12360==    by 0x1576C9: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) (gtest.cc:2483)
==12360==    by 0x14CFEE: testing::Test::Run() [clone .part.562] (gtest.cc:2522)
==12360==    by 0x14D289: Run (gtest.cc:2513)
==12360==    by 0x14D289: testing::TestInfo::Run() [clone .part.563] (gtest.cc:2703)
==12360==    by 0x14D43F: Run (gtest.cc:2677)
==12360==    by 0x14D43F: testing::TestCase::Run() [clone .part.564] (gtest.cc:2825)
==12360==    by 0x14DA44: Run (gtest.cc:2811)
==12360==    by 0x14DA44: testing::internal::UnitTestImpl::RunAllTests() (gtest.cc:5216)
==12360==    by 0x157BD9: HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (gtest.cc:2447)
==12360==    by 0x157BD9: bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) (gtest.cc:2483)
==12360==    by 0x14DC9E: testing::UnitTest::Run() (gtest.cc:4824)
==12360==    by 0x11C4FF: RUN_ALL_TESTS (gtest.h:2370)
==12360==    by 0x11C4FF: main (gtest_main.cc:36)
==12360== 
/home/ANT.AMAZON.COM/zacmicha/ros2_ws-system_metrics_collector/src/system_metrics_collector/system_metrics_collector/test/system_metrics_collector/test_linux_cpu_measurement.cpp:262: Failure
Value of: std::isnan(cpu_active_percentage)
  Actual: false
Expected: true
thomas-moulard commented 4 years ago

Most likely going to be automatically closed once Devin is done with the testing refactoring.

dabonnie commented 4 years ago

Moved to done in order to close during the sprint review meeting.