ros-tooling / topic_tools

Tools for directing, throttling, selecting, and otherwise manipulating ROS 2 topics at a meta-level.
Apache License 2.0
71 stars 33 forks source link

Use Ubuntu Noble distro for ci on rolling #107

Closed MichaelOrlov closed 3 months ago

MichaelOrlov commented 3 months ago
christophebedard commented 3 months ago

We could just merge #106, since it has those changes.

MichaelOrlov commented 3 months ago

@christophebedard I would prefer to fix CI scripts in a separate PR.

christophebedard commented 3 months ago

Sure, that's fine with me.

MichaelOrlov commented 3 months ago

https://github.com/Mergifyio backport jazzy

mergify[bot] commented 3 months ago

backport jazzy

❌ No backport have been created

* Backport to branch `jazzy` failed GitHub error: ```Branch not found```
MichaelOrlov commented 3 months ago

@christophebedard @clalancette There is no jazzy branch for topic_tools. Did we miss something?

christophebedard commented 3 months ago

This repo isn't part of the ROS 2 core, and no one created the branch.

christophebedard commented 3 months ago

When we do create the jazzy branch, we should update the branch name in rosdistro https://github.com/ros/rosdistro/blob/258800ad9291feb269da3fcbbe8764b98fc94a6b/jazzy/distribution.yaml#L7595 and in the release repo https://github.com/ros2-gbp/topic_tools-release/blob/d3ec3544366ec4e953ca4d5c899e70b4ed5919d9/tracks.yaml#L80

christophebedard commented 3 months ago
  1. :heavy_check_mark: Create jazzy branch from rolling in this repo, and add protection here: https://github.com/ros-tooling/topic_tools/settings/branches
  2. Change version: rolling in the rosdistro jazzy/distribution.yaml entry for topic_tools to version: jazzy: https://github.com/ros/rosdistro/blob/258800ad9291feb269da3fcbbe8764b98fc94a6b/jazzy/distribution.yaml#L7595-L7612
  3. Change devel_branch for Jazzy from rolling to jazzy in the release repo: https://github.com/ros2-gbp/topic_tools-release/blob/d3ec3544366ec4e953ca4d5c899e70b4ed5919d9/tracks.yaml#L95

At this point, Rolling and Jazzy will still have the same version of topic_tools, which is fine.

  1. Create a new release for Rolling on rolling, bumping the major version
  2. Create a new release for Jazzy on jazzy, bumping the minor version