ros-tooling / topic_tools

Tools for directing, throttling, selecting, and otherwise manipulating ROS 2 topics at a meta-level.
Apache License 2.0
71 stars 33 forks source link

Fix Jazzy release to refer to the Jazzy branch for topic_tools repo #108

Closed MichaelOrlov closed 1 week ago

MichaelOrlov commented 2 months ago

Description

We forgot to create a separate jazzy branch for the topic_tools repo and released it to Jazzy from the rolling branch.

Need to fix the Jazzy release to refer to the appropriate jazzy branch

Related Issues

Completion Criteria

At this point, Rolling and Jazzy will still have the same version of topic_tools, which is fine.

MichaelOrlov commented 2 months ago

@christophebedard I think that creating a new release for Rolling on rolling and bumping the major version without any changes to it doesn't make sense and has no value.

I thought that it make sense to merge #106 on rolling first then bump the major version and do release on rolling. The same could be done for Jazzy - backport #106 to Jazzy branch and then bump minor version on jazzy release and do a release for jazzy.

@clalancette @marcoag - any concern about this ^^^?

christophebedard commented 2 months ago

Yeah that's fine. The current version is 1.3.0, so Rolling would then have 1.4.0 and Jazzy would have 1.3.1.

clalancette commented 2 months ago

@christophebedard I think that creating a new release for Rolling on rolling and bumping the major version without any changes to it doesn't make sense and has no value.

We do this for all of the core ROS 2 repositories (though we bump the minor version, not the major). That is, if the version of a Jazzy package is X.Y.Z, we make sure that Rolling is at least X.Y+1.Z. And thereafter, we only ever bump the patch version for Jazzy. It isn't ideal, as we can't really encode semver that way, but it ensures that we never "interleave" version numbers between Rolling and released distributions. It also ensures that we can always release, even if there doesn't happen to be PRs that we want merge in.

For this package, you can do it however you want. If you just want to get the version numbers straight now, you can bump it without any changes. If you'd rather get #106 in first, then merge that, bump the major (or minor), and backport to Jazzy, which will only bump the minor (or patch).