ros-tooling / topic_tools

Tools for directing, throttling, selecting, and otherwise manipulating ROS 2 topics at a meta-level.

Apache License 2.0

79 stars 34 forks source link

Fix unsubscribing when switching to none topic #111

Closed adamlm closed 2 months ago

adamlm commented 2 months ago

Description

This PR fixes an issue with the mux node where switching to the __none topic did not cause the node to unsubscribe from its previous topic.

The node now calls the ToolBaseNode::make_subscribe_unsubscribe_decisions() function after assigning input_topic_ to NONE_TOPIC.

Closes #110

How was this tested?

I added a new unit test.

christophebedard commented 2 weeks ago

@mergifyio backport jazzy

mergify[bot] commented 2 weeks ago

backport jazzy

✅ Backports have been created

* [#118 Fix unsubscribing when switching to none topic (backport #111)](https://github.com/ros-tooling/topic_tools/pull/118) has been created for branch `jazzy`