ros-tooling / topic_tools

Tools for directing, throttling, selecting, and otherwise manipulating ROS 2 topics at a meta-level.
Apache License 2.0
71 stars 33 forks source link

Make compatible with windows #68

Closed anrp-tri closed 1 year ago

christophebedard commented 1 year ago

Thanks for the PR! I've changed the base branch from humble to main. We'll backport to humble after this is merged. Could you just rebase your commit on the main branch? And also could you sign off your commit (git commit --amend --no-edit -s)?

anrp-tri commented 1 year ago

Done.

emersonknapp commented 1 year ago

Pulls: ros-tooling/topic_tools#68 Gist: https://gist.githubusercontent.com/emersonknapp/6344476197d93205d189a2cf57bae540/raw/e67e903ac4f5f0625e6562d407542891cc75041f/ros2.repos BUILD args: --packages-above-and-dependencies topic_tools TEST args: --packages-above topic_tools ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12331

emersonknapp commented 1 year ago

Thanks for this patch - we haven't run Windows CI on this package yet, I'm glad it looks like only a small change to make it go. Looking forward to seeing if the CI reveals any extra warnings or other things. However if this makes build go from red->yellow that's still fine by me and I'll be happy to merge it, even if not green

emersonknapp commented 1 year ago

@mergifyio backport iron humble

mergify[bot] commented 1 year ago

backport iron humble

✅ Backports have been created

* [#69 Make compatible with windows (backport #68)](https://github.com/ros-tooling/topic_tools/pull/69) has been created for branch `iron` * [#70 Make compatible with windows (backport #68)](https://github.com/ros-tooling/topic_tools/pull/70) has been created for branch `humble`