search

ros-tooling / topic_tools

Tools for directing, throttling, selecting, and otherwise manipulating ROS 2 topics at a meta-level.
Apache License 2.0
79 stars 34 forks source link

Fix windows warnings #71

Closed emersonknapp closed 1 year ago

emersonknapp commented 1 year ago

Discovered in https://ci.ros2.org/job/ci_windows/19826/ via https://github.com/ros-tooling/topic_tools/pull/68

emersonknapp commented 1 year ago

I'll run full ci.ros2.org on this to actually look for greens across the board, then can backport and make sure Humble/Iron also all greens, then will cut releases with the new branches

emersonknapp commented 1 year ago

Pulls: ros-tooling/topic_tools#71 Gist: https://gist.githubusercontent.com/emersonknapp/64914eb5816cc95ae84edff9be760aac/raw/e985fc1b6d3ddc0aa3a43345a47c76e4d523498b/ros2.repos BUILD args: --packages-above-and-dependencies topic_tools TEST args: --packages-above topic_tools ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12337

emersonknapp commented 1 year ago

Rebuild above

emersonknapp commented 1 year ago
emersonknapp commented 1 year ago

@mergifyio backport humble iron

mergify[bot] commented 1 year ago

backport humble iron

✅ Backports have been created

* [#73 Fix windows warnings (backport #71)](https://github.com/ros-tooling/topic_tools/pull/73) has been created for branch `humble` * [#74 Fix windows warnings (backport #71)](https://github.com/ros-tooling/topic_tools/pull/74) has been created for branch `iron`