search

ros-tooling / topic_tools

Tools for directing, throttling, selecting, and otherwise manipulating ROS 2 topics at a meta-level.
Apache License 2.0
71 stars 33 forks source link

[FIX] convert rclcpp to chrono #80

Closed wodtko closed 1 year ago

wodtko commented 1 year ago

With a recent update of rclcpp::Rate the return value of .period() changed to rclcpp::Duration, thus, it must be converted to the std::chrono::duration used here.

https://github.com/ros2/rclcpp/commit/bc435776a257fcf76c5b0124bec26f6824342e34 here are the respective changes in rclcpp

action-ros-ci-repos-supplemental: https://raw.githubusercontent.com/ros2/ros2/rolling/ros2.repos

christophebedard commented 1 year ago

It looks like this change (i.e., API break) was unintentional. It's being fixed in https://github.com/ros2/rclcpp/pull/2301.

We won't need this PR, unless they actually deprecate this one and add a new Rate::period() method that returns a Duration. Until then, I'll close this. Thanks for contributing, though!