Allow launching from a launch file, use rospy.myargv() to remove ROS remapping arguments

kartikmohta commented 7 years ago

Required to allow launching from a launch file, otherwise get errors of the type:

usage: smach_viewer.py [-h] [-f]
smach_viewer.py: error: unrecognized arguments: __name:=smach_viewer

furushchev commented 7 years ago

+1 for the bugfix, though there are also lots of unrelated changes included...

furushchev commented 7 years ago

Just to clarify, without this PR, launching smach_viewer from launch file fails:

<launch>
  <node name="smach_viewer" pkg="smach_viewer" type="smach_viewer.py" />
</launch>

SUMMARY
========

PARAMETERS
 * /rosdistro: indigo
 * /rosversion: 1.11.21

NODES
  /
    smach_viewer (smach_viewer/smach_viewer.py)

ROS_MASTER_URI=http://localhost:11311

core service [/rosout] found
process[smach_viewer-1]: started with pid [15151]
usage: smach_viewer.py [-h] [-f]
smach_viewer.py: error: unrecognized arguments: __name:=smach_viewer __log:=/home/furushchev/.ros/log/30411004-78dc-11e7-8090-a434d9dcb7b6/smach_viewer-1.log
[smach_viewer-1] process has died [pid 15151, exit code 2, cmd /opt/ros/indigo/lib/smach_viewer/smach_viewer.py __name:=smach_viewer __log:=/home/furushchev/.ros/log/30411004-78dc-11e7-8090-a434d9dcb7b6/smach_viewer-1.log].
log file: /home/furushchev/.ros/log/30411004-78dc-11e7-8090-a434d9dcb7b6/smach_viewer-1*.log
all processes on machine have died, roslaunch will exit
shutting down processing monitor...
... shutting down processing monitor complete
done

kartikmohta commented 7 years ago

@furushchev Just add ?w=1 to the end of the URL to ignore the whitespace changes when looking at the commit changes.

furushchev commented 7 years ago

@kartikmohta I think the change rather should be in another pull request.