search

ros-visualization / executive_smach_visualization

A ROS-based introspection tool for visualizing the structure and state of SMACH plans.
18 stars 68 forks source link

Port smach_viewer to rqt_smach #2

Open jbohren opened 11 years ago

jbohren commented 11 years ago

Moved from https://github.com/ros-visualization/rqt/issues/15

furushchev commented 9 years ago

catkinized https://github.com/ros-visualization/executive_smach_visualization/pull/10

vincentrou commented 7 years ago

It seems that there is a multiple forks with rqt_smach (like here https://gist.github.com/matt3o/88bced95dba37a8932a51904d0734dff from @matt3o). It could be interesting to merge them to have an official version and release. @k-okada are you doing only release or do you merge pull request too ? Otherwise I can help to maintain this package too.

k-okada commented 7 years ago

Hi, we're currently writing detailed document on our efforts on ROS Orphaned Package Maintainer initiative, but my main motivation is to keep continue releasing with minimum efforts. So releasing is most important, and I can merge, but looking into the patches, give feedback, run test code feels too much. So if there is other volunteer who can share this effort, that's very helpful.

Anyway please send us the PR for rqt_smach and if we see multiple confirmation, we can merge and release new version.

P.S. If you're willing to take over this job and back this package from orphaned status, that's great!.

matt3o commented 7 years ago

Hey guys, I am the author of the gist. If I can be of any help - tell me. My intention to split off an own fork was purely based on the decision that this repo didn't seem to accept any PRs any longer. If desired I can surely open a PR - however I only made a few base fixed to let this run on kinetic at all. I believe that xdot is deprecated as well - but my version is still using it. For my fixes to run correctly we also need to update jbohrens xdot or fork an own xdot repo which I did. Both sound undesirable to me.

Any ideas on how we shall proceed?

k-okada commented 7 years ago

current smach_viewer contains xdot within it's package directory. I know this is not a clean solution, but could not find other one. May be this could be one possibility for you to create new PR for your rqt_samch, with out depending on xdot fork. https://github.com/ros-visualization/executive_smach_visualization/tree/indigo-devel/smach_viewer/src/smach_viewer/xdot

matt3o commented 7 years ago

Sorry for the late reply - I'm rather busy right now. To make sure we are talking of the same changes: 1) We (you?) will create an kinetic devel branch on executive_smach_visualization 2) Just checked the official executive_smach_visualization repo but it only contains smach_viewer. I could only make rqt_smach work on kinetic. Thus I'd add a new top level folder from my executive_smach_visualization repo which is called rqt_smach. The remaining question for me would be - where would I push the xdot package to in this case? 3) You could go ahead and create a package from it

If that's what you intended answer the questions and give me your go so that I can start the necessary PRs.

k-okada commented 7 years ago
  1. ok created 'kinetic' devel branch, please create PR against this branch.
  2. please add xdot source under rqt_smach/src/rqt_smach/xdot similar to https://github.com/ros-visualization/executive_smach_visualization/tree/kinetic-devel/smach_viewer/src/smach_viewer/xdot