[FIX] 'Jump' object has no attribute 'url'

ros-visualization / executive_smach_visualization

A ROS-based introspection tool for visualizing the structure and state of SMACH plans.

18 stars 68 forks source link

[FIX] 'Jump' object has no attribute 'url' #31

Closed Combinacijus closed 4 years ago

Combinacijus commented 4 years ago

Fix for AttributeError: 'Jump' object has no attribute 'url' To reproduce:

roscore
rosrun smach_viewer smach_viewer.py
Press "+" button to increase depth and hover over/click text "Path not available"
Error prints in terminal

k-okada commented 4 years ago

thaks for contribution, please create PR against our latest melodic-devel branch https://github.com/ros-visualization/executive_smach_visualization/tree/melodic-devel

Combinacijus commented 4 years ago

@k-okada changed it to melodic-devel. But I would guess same problem occurs in other branches too.

k-okada commented 4 years ago

@Combinacijus thanks! can you fix

 Sorry: IndentationError: unindent does not match any outer indentation level (smach_viewer.py, line 713)

error?

Combinacijus commented 4 years ago

@k-okada oh sorry for such a silly mistake. That's what you get by editing files inside Github. Now it's strange to have two commits I'm still learning how Github works so is it normal to have many commits to fix initial commit? I would say a single commit with all the final changes would look nicer

k-okada commented 4 years ago

@Combinacijus thaks, I also prefer single commit, for simple fix, but it is ok for now.