search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

[Fix] Replace PythonInterp to Python3 COMPONENTS #108

Closed homalozoa closed 2 years ago

homalozoa commented 2 years ago

As description in https://cmake.org/cmake/help/v3.12/module/FindPythonLibs.html and https://cmake.org/cmake/help/v3.12/module/FindPythonInterp.html . Using find_package(PythonLib) and find_package(PythonInterp) are deprecated.

Also, ${PYTHON_VERSION_MAJOR} and ${PYTHON_VERSION_MINOR} are not result variables of FindPython3. ${Python3_VERSION}, ${Python3_VERSION_MAJOR} and ${Python3_VERSION_MINOR} are new variables.

Signed-off-by: Homalozoa nx.tardis@gmail.com

cottsay commented 2 years ago

This appears to resolve recent issues I'm seeing on Fedora and RHEL 8.5. Thanks for the patch!

cottsay commented 2 years ago

Fresh CI:

I'd be fascinated to know why the other CI run didn't fail, but successfully resolved the issue on RHEL.

clalancette commented 2 years ago

All of the failures are in qt_dotgraph, and are there on the nightlies. So I'm going to go ahead and merge this, thanks for the contribution.

cottsay commented 2 years ago

@Mergifyio backport galactic-devel :face_exhaling: Fine, I'll do it myself!