search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Remove pyqt from default binding order for macOS #118

Closed srmainwaring closed 1 year ago

srmainwaring commented 2 years ago

This PR removes pyqt from the list of default bindings when running macOS ('Darwin').

Partial fix for #103. Details in https://github.com/ros-visualization/python_qt_binding/issues/103#issuecomment-1231062249 for accompanying changes required in https://github.com/ros-visualization/qt_gui_core.

The brew formula for pyside@2 is keg only, to build and run using PySide2 set the environment variables:

export CMAKE_PREFIX_PATH=/usr/local/opt/pyside@2:$CMAKE_PREFIX_PATH
export PATH=/usr/local/opt/pyside@2/bin:$PATH
export PYTHONPATH=$PYTHONPATH:/usr/local/opt/pyside@2/lib/python3.10/site-packages
cottsay commented 1 year ago

I'm not entirely sure why yet, but this change regressed builds of qt_gui_cpp on RHEL 9. I see:

EDIT: Scratch that, something else caused the regression. Still investigating...