Update sip_helper to use python header dirs

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding

BSD 3-Clause "New" or "Revised" License

34 stars 54 forks source link

Update sip_helper to use python header dirs #12

Closed NikolausDemmel closed 10 years ago

NikolausDemmel commented 10 years ago

This fixes https://github.com/ros-visualization/qt_gui_core/pull/46 and https://github.com/ros-visualization/rviz/pull/788; needed at least on OS X, likely some other platforms as well.

NikolausDemmel commented 10 years ago

Addressed your comment and also added the specific version for PythonInterp.

dirk-thomas commented 10 years ago

Great, thanks for the patch.

NikolausDemmel commented 10 years ago

I see you released this for indigo. Can we get it into hydro as well? Or is this on the agenda already?

dirk-thomas commented 10 years ago

When several days have past after an Indigo release of a repo I will consider all patches for backport to Hydro. The idea is that if any regressions appear on Indigo it doesn't effect Hydro immediately.

This one can definitely be backported.

Update: it has been released into Hydro in https://github.com/ros/rosdistro/commit/240e1aa51c71a467a1432252330107d2ddf9b38a