search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Fix to allow ninja to use make for generators #123

Closed mjcarroll closed 1 year ago

mjcarroll commented 1 year ago

There is an issue when building qt_gui_cpp with ninja, and it is traced back to python_qt_binding.

This allows ninja to find the make executable and use it for this particular step. The alternative would be to make the generator create ninja-files in addition to makefiles, but that seems like more work, given that make should be available on all platforms.

CMake Error:
  Running

   '/usr/bin/ninja' '-C' '/home/mjcarroll/workspaces/ros2_rolling/build/qt_gui_cpp' '-t' 'recompact'

  failed with:

   ninja: error: build.ninja:633: bad $-escape (literal $ must be written as $$)
mjcarroll commented 1 year ago
peci1 commented 6 months ago

Could I ask for this to be backported to Noetic? It prevents me from building RViz with ninja: https://github.com/ros-visualization/python_qt_binding/issues/111#issuecomment-2104306840 .