search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Switch to C++17 for SIP and Shiboken #135

Closed christophebedard closed 6 months ago

christophebedard commented 6 months ago

Relates to https://github.com/ros-visualization/qt_gui_core/pull/288

Relates to https://github.com/ros/pluginlib/pull/254

Switch to C++17 to be able to use std::filesystem when building SIP or Shiboken bindings.

I'm doing this mainly for qt_gui_core and I didn't seem to need the change for Shiboken, but we'll probably hit the same issue as we migrate everything else to C++17's std::filesystem. See the corresponding docs for Shiboken: https://doc.qt.io/qtforpython-5/shiboken2/shibokengenerator.html#usage.

I think we can merge this without negatively affecting anything.

clalancette commented 6 months ago

Here's CI with just this PR in place: