search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

Suppress warning from Shiboken2. #137

Closed clalancette closed 4 months ago

clalancette commented 4 months ago

The comment has more information on why we are doing this.

Fixes https://github.com/ros-visualization/qt_gui_core/issues/291

clalancette commented 4 months ago

CI:

ahcorde commented 4 months ago

https://github.com/Mergifyio backport jazzy

mergify[bot] commented 4 months ago

backport jazzy

✅ Backports have been created

* [#138 Suppress warning from Shiboken2. (backport #137)](https://github.com/ros-visualization/python_qt_binding/pull/138) has been created for branch `jazzy`
Crola1702 commented 4 months ago

I'm seeing in RHEL Debug, repeated and packaging:

--- stderr: qt_gui_cpp
00:12:27.703 CMake Error at /home/jenkins-agent/workspace/nightly_linux-rhel_debug/ws/install/python_qt_binding/share/python_qt_binding/cmake/shiboken_helper.cmake:27 (cmake_policy):
00:12:27.703   Policy "CMP0148" is not known to this version of CMake.
00:12:27.703 Call Stack (most recent call first):
00:12:27.703   src/qt_gui_cpp_shiboken/CMakeLists.txt:43 (include)
ahcorde commented 4 months ago

@Crola1702 This PR https://github.com/ros-visualization/python_qt_binding/pull/139 fixed the issue

Crola1702 commented 4 months ago

Makes sense. Just noticed that the build was run 9h ago. Thanks!