search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

update cmake version #139

Closed ahcorde closed 4 months ago

ahcorde commented 4 months ago

This PR https://github.com/ros-visualization/python_qt_binding/pull/137 introduces a regresion. CMP0148 is new in CMake 3.27. The main CMakeLists.txt is using 3.5, I updated the cmake/shiboken_helper.cmake version to 3.5 too.

ahcorde commented 4 months ago
ahcorde commented 4 months ago

The CMake version installed in rhel is:

10:03:04  cmake                                x86_64  3.20.2-9.el9_3           appstream  6.7 M

Trying a different approach

ahcorde commented 4 months ago
clalancette commented 4 months ago

(and let's remember to backport this to Jazzy as well)

clalancette commented 4 months ago

@Mergifyio backport jazzy

mergify[bot] commented 4 months ago

backport jazzy

✅ Backports have been created

* [#140 update cmake version (backport #139)](https://github.com/ros-visualization/python_qt_binding/pull/140) has been created for branch `jazzy` but encountered conflicts