search

ros-visualization / python_qt_binding

http://wiki.ros.org/python_qt_binding
BSD 3-Clause "New" or "Revised" License
34 stars 54 forks source link

PyQt 4.11 compatibility #15

Closed pallegro closed 9 years ago

pallegro commented 10 years ago

Starting in PyQt 4.11, there is no pyqtconfig, so this patch imitates it when its not found. pyqtconfig.QtGuiModuleMakefile simply calls sipconfig.SIPModuleMakefile with qt=['QtCore', 'QtGui'], thus this patches has no effect if pyqtconfig is found (i.e. if the user has PyQt <=4.10)

bchretien commented 9 years ago

Note: this PR aims at solving #13.

pallegro commented 9 years ago

/usr/share/sip/PyQt4 is what's used by Ubuntu Utopic, so I've updated the path to that.

bchretien commented 9 years ago

If I'm not mistaken, /usr/share/sip/PyQt4 is the default path for PyQt4, so the one that packagers keep for the PyQt4 version associated with their distribution's default Python version (Python 3 for Arch, Python 2 for Ubuntu). Arch's PKGBUILD for PyQt4 seems to confirm it.

I guess that if this is the only part really specific for Arch, I can just keep a good ol' sed replace in the PKGBUILD, unless there's a way to get these values from somewhere else.

bchretien commented 9 years ago

But as you said on the AUR, if sip files in /usr/share/*PyQt4 are identical, this could be solved in Arch's PyQt4 package.

dirk-thomas commented 9 years ago

Superseded by #21.